As of Drupal 9, no core themes declare a dependency on Classy. As I understand it, Classy will be going away in Drupal 10. In #3247901: ContentTranslationUITestBase should not rely on Classy the last test references to Classy were removed from core.

Unless we are expecting Classy-specific markup in tests, we should be specifying another core theme such as Stark instead. Currently there are two entity_embed tests that require Classy.

CommentFileSizeAuthor
#10 3248476-remove-test-dependency-on-classy.patch4.21 KBdave reid
#8 3248476-remove-test-dependency-on-classy.patch4.21 KBdave reid
#5 3248476-remove-test-dependency-on-classy.patch2.82 KBdave reid
#4 3248476-remove-test-dependency-on-classy.patch1.93 KBdave reid
#2 entity_embed-3248476-2-remove_classy_test_dependency.patch1.12 KBdaniel_j

Comments

daniel_j created an issue. See original summary.

daniel_j’s picture

daniel_j commented
StatusFileSize
new entity_embed-3248476-2-remove_classy_test_dependency.patch1.12 KB
daniel_j’s picture

daniel_j commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 3248476-remove-test-dependency-on-classy.patch1.93 KB

Updated patch that should fix the test failures.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 3248476-remove-test-dependency-on-classy.patch2.82 KB

Correct version of the patch with all the changes.

The last submitted patch, 4: 3248476-remove-test-dependency-on-classy.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 5: 3248476-remove-test-dependency-on-classy.patch, failed testing. View results

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3248476-remove-test-dependency-on-classy.patch4.21 KB

Status: Needs review » Needs work

The last submitted patch, 8: 3248476-remove-test-dependency-on-classy.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 3248476-remove-test-dependency-on-classy.patch4.21 KB

  • Dave Reid committed 27853bc on 8.x-1.x 
    Issue #3248476 by Dave Reid, daniel_j: Removed test dependency on the...
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #10 to 8.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.