Installing an installation profile might fail in some circumstances when for some reason webform_components() is called before all modules where activated. For me this led to a hard to debug code where webform_component_defaults() failed to give a result although the module defining the the component type’s function was already enabled.
In one single script or request:
Use drupal_static() or the drupal_static_fast pattern.
Note that this only works if a patch for #1891356: D7: Reset drupal static caches when a module is enabled or disabled. is applied to Drupal core as well.
See patch / review status.
None.
None.
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | webform-3247737-drupal_static-3.patch | 560 bytes | torotil |
| #2 | webform-3247737-drupal_static-2.patch | 1.82 KB | torotil |
Comments
Comment #2
torotil commentedComment #3
torotil commented… and without debug output ;-)
Comment #4
torotil commentedComment #5
damienmckennaI wonder if this is what's causing one of our D7 sites to occasionally loose its webform components, or for some individual components to not show; both problems are resolved by clearing the caches.
Comment #6
damienmckennaI wonder if this is the same problem: #2427219: Webform disappears. Flushing the cache needed to make it reappear again
Comment #7
torotil commentedIt could be. One explanation for what you describe would be if some module would call
webform_components()before the full bootstrap is done and all modules are loaded. Then the incomplete (or empty) list of components would persist for the rest of the request.Comment #8
damienmckennaThat's what I'm thinking, though after the initial load the forms stay broken until the caches are cleared, which could be several days later. It doesn't happen very often, but in the past year it's happened at least twice, and each time a cache-clear fixed it.
We're going to test out your patch and will keep you posted.
Comment #9
liam morlandIs this patch tested and safe to apply even if #1891356: D7: Reset drupal static caches when a module is enabled or disabled. is not patched?
It would be great if someone would test to see if it fixes #2427219: Webform disappears. Flushing the cache needed to make it reappear again. If so, please post the fix there.
Comment #10
damienmckennaWe set it up on a large D7 site that gets a lot of Webform traffic that was running into occasional problems of the components disappearing. The problem would only happen once every few months so it's hard to replicate. I'll keep you posted.
Comment #11
liam morlandDrupal 7 is no longer supported. If this applies to a supported version, please re-open.