Integration with gin_login module [#3247198]

We use the module 'gin_login' on our sites. We would like that the 'email code verification' page looks like other gin_login pages. In the 'gin_login' module is already a patch, which enables such integration (see: #3246426).

In this issue I will prepare a proposal of the integration.

Issue fork email_tfa-3247198

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3247198-integration-with-ginlogin changes, plain diff MR !4
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

2 November 2021 at 11:19

Antonín Slejška created an issue. See original summary.

Comment #2

2 November 2021 at 11:24

Antonín Slejška opened merge request !4

Comment #3

antonín slejška commented 2 November 2021 at 11:26

Status:

Active

» Needs review

Proposal: https://git.drupalcode.org/project/email_tfa/-/merge_requests/4

Patch: https://git.drupalcode.org/project/email_tfa/-/merge_requests/4.patch

Comment #4

antonín slejška commented 2 November 2021 at 14:45

We have found, that there is a little problem with admin toolbar classes in the tag 'body'. The commit https://git.drupalcode.org/issue/email_tfa-3247198/-/commit/93afa0e7ae40... solves the problem. But the email_tfa module has to have higher weight as the module toolbar. In the hook comment is it described.