Problem/Motivation

The filterStatus override includes a call to jQuery.removeOnce() to allow filter forms to rebuild on AJAX calls. jQuery once has been replaced with drupal/once, so we should use that instead.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork ckeditor5-3246605

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3244855: Regression in Drupal 9.3.x due to jQuery.once deprecation

Made apparent by #3244855: Regression in Drupal 9.3.x due to jQuery.once deprecation.

Triggered a test run on a no-op patch: #3233107-3: [ignore, testing issue] Fake bug report. Failures confirmed: https://www.drupal.org/pift-ci-job/2221513.

bnjmnm opened merge request !145

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Reviewed & tested by the community

Can't find anything to complain about in the changes 🤓

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

Uh oh, one test failed!

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs work » Postponed

This will likely be addressed in #3246647: Filter settings are not removed when a filter is disabled. Close that if that lands with the solution that uses drupal/once to replace jQuery.once

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Postponed » Closed (outdated)

This was indeed fixed in #3246647: Filter settings are not removed when a filter is disabled.

Wim Leers closed merge request !145