Problem/Motivation

We changed the ds9.txt file in #3209934: Fix spelling for 46 migrate related words but we didn't update the file_managed table

Steps to reproduce

Proposed resolution

Update the file size in drupal7.php

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#3 3246053-2.patch501 bytesquietone
#2 3246053-2.txt501 bytesquietone

Comments

alexpott created an issue. See original summary.

quietone’s picture

Issue summary: View changes
Status: Active » Needs review
Issue tags: +Bug Smash Initiative, +qui
StatusFileSize
new501 bytes

The size of this file, ds9.txt. is not tested in a core migration test so the change was not picked up. In order to add a test FileMigrationSetupTrait needs to be modified to handle more that one file. Currently, I don't think that work is necessary because the file migration is tested and no new files are being added to the fixture. Of course the latter one may change but right now I can't think of any open issue that would require that. The problem arose from doing spelling change fixes to the file ds9.txt and that will not happen again because the file only contains, the '*' character.

And just to note that there is an issue to update the fixture, #3219539: Update Drupal 7 migration database fixture which has some activity this week.

quietone’s picture

StatusFileSize
new501 bytes

That was meant to be a patch.

longwave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -qui

The file is now 4 bytes so this is correct. There are two references to ds9.txt in the codebase and only one mentions the file size, so there are no other changes to make here.

quietone’s picture

Issue tags: +Quick fix

I think this qualifies as a quick fix.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Test-only fix backported to 9.3.x.

Committed and pushed a911353469 to 9.4.x and 52524c98bc to 9.3.x. Thanks!

  • alexpott committed a911353 on 9.4.x
    Issue #3246053 by quietone: Fix file_managed table for ds9.txt
    

  • alexpott committed 52524c9 on 9.3.x
    Issue #3246053 by quietone: Fix file_managed table for ds9.txt
    
    (cherry...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.