Problem/Motivation

There a few references to Action plugins that are no longer provided by the node module:

"For a working example, see \Drupal\node\Plugin\Action\UnpublishNode" in https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Annotation!Action...

"@see \Drupal\node\Plugin\Action\PublishNode" in https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F...

Steps to reproduce

N/A

Proposed resolution

Update both of these files to use:

@see \Drupal\Core\Action\Plugin\Action\PublishAction

Remaining tasks

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

Issue fork drupal-3245820

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paul121 created an issue. See original summary.

paul121 opened merge request !1339

paul121’s picture

paul121 commented
Status: Active » Needs review
dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work
Issue tags: +Bug Smash Initiative

Thanks for finding and reporting this. Commented at the MR. Yes, I think it's better to use @see and keep the reference.

paul121’s picture

paul121 commented
Status: Needs work » Needs review

Thanks @dww. Just made a change to use @see and keep the reference to the core UnpublishAction.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Works for me. The bot should be green for this. Simple change to fix a docs bug. RTBC. The bot can contradict me if a test fails (although I think that'd only be from a random fail, not due to the MR changes).

Thanks!
-Derek

dww credited eojthebrave.

dww’s picture

dww
we/he/they
commented
Related issues: +#3185250: If I spend time reviewing an issue with code comments in gitlab committers have to do work to give credit

p.s. Since #3185250: If I spend time reviewing an issue with code comments in gitlab committers have to do work to give credit is still open, we have to manually credit @eojthebrave who provided a valuable review in the MR but didn't comment in here.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 055054d592 to 9.4.x and 12658bad82 to 9.3.x. Thanks!

Backported to 9.3.x since this is a docs only change.

  • alexpott committed 055054d on 9.4.x 
    Issue #3245820 by paul121, dww, eojthebrave: Remove references to...

  • alexpott committed 12658ba on 9.3.x 
    Issue #3245820 by paul121, dww, eojthebrave: Remove references to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.