Problem/Motivation

If my only interaction with an issue is through merge request review there are a number of problems:

  • The interactions do not count in the commit message credit box
  • A committer has to know to add me via the credit others box
  • The issue does not appear in my issue tracker

Proposed resolution

Much of this stem from the decision to not use issue comments to communicate interaction with the merge request. (I'm sure there are good reasons for this - I'd love to see them though).

Remaining tasks

User interface changes

API changes

Data model changes

Comments

alexpott created an issue.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented

The main reason that interaction on gitlab does not become a first class comment is that the data on gitlab is mutable, and we'd have to do a sychronization step to keep them in sync. Additionally, because Gitlab can have threaded comments, itd be difficult to figure out how to map that back to d.o.

The way it's currently implemented allows Gitlabs to be the source of truth, and d.o. just displays the gitlab activity in the issue context, by querying the gitlab api.

drumm’s picture

drumm
he/him
Location NY, US
commented

Since we are loading them all, we should be able to sum up how many notes someone has made in the MR, and add that into the credit summary.

drumm’s picture

drumm
he/him
Location NY, US
commented

Solving this can also add to the users available for matching up merge request activity to Drupal.org users.

For example, https://www.drupal.org/project/ckeditor5/issues/3194650#mr4-note12935, currently tim.plunkett & lauriii have worked on the merge request, but haven’t commented in Drupal.