Problem/Motivation

Discovered while working on #3232052: Drupal 10 & CKEditor 5 readiness. Will be obsolete once #3222797: Upgrade path from CKEditor 4's StylesCombo to CKEditor 5's Style is done.

Steps to reproduce

  1. Go to text format using CKEditor 4 that has the StylesCombo plugin configured
  2. During automatic migration of its settings, it will crash

Proposed resolution

  • Add failing test
  • Fix

Remaining tasks

N/A

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork ckeditor5-3244911

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wim Leers created an issue. See original summary.

Wim Leers opened merge request !131

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review

Test pushed, should fail 🤞

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Also double checked that null was already documented as a valid return value for Drupal\ckeditor5\Plugin\CKEditor4To5UpgradePluginInterface::mapCKEditor4SettingsToCKEditor5Configuration, and it was reflected both in the typehint and the docblock.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Thanks! Assigning credit prior to merging…

  • Wim Leers committed 5c4433a on 1.0.x 
    Issue #3244911 by Wim Leers, lauriii: Automatic upgrade path failing...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.