Problem/Motivation

In Drupal 9.3 the core/jquery.once library is being deprecated. The element.horizontal_tabs library assumes it will be loaded due to its dependency on core/drupal.collapse. However this is no longer true.

Steps to reproduce

See #3244855: Regression in Drupal 9.3.x due to jQuery.once deprecation

Proposed resolution

Add explicit dependencies to the libraries. While core may fix this it is best to be explicit about dependencies anyway.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 3244858-add-explicit-dependencies.6.patch1.08 KBalexpott

Issue fork field_group-3244858

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !7

alexpott opened merge request !8

alexpott closed merge request !7

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
StatusFileSize
new 3244858-add-explicit-dependencies.6.patch1.08 KB

For some reason the CI is not running on the MR :(

Here's a patch.

  • nils.destoop committed 3933255 on 8.x-3.x authored by alexpott 
    Issue #3244858 by alexpott: Add explicit dependencies to field_group...
nils.destoop’s picture

nils.destoop commented
Status: Needs review » Fixed

Thx :). Committed it to dev.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.