Main Page Content label [#3243235]

Problem/Motivation

The main page content block label appears on every page as printed text. I believe it's meant to be hidden so the words "Main page content" don't print above the main page content block.

Issue fork simplytest-3243235

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3243235-main-page-content changes, plain diff MR !100
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

3243235-visually-hidden

changes, plain diff MR !101

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

13 October 2021 at 01:15

Greg Boggs created an issue. See original summary.

Comment #2

13 October 2021 at 01:17

Greg Boggs opened merge request !100

Comment #3

15 October 2021 at 04:05

bernardm28 made their first commit to this issue’s fork.

Comment #4

15 October 2021 at 04:09

bernardm28 opened merge request !101

Comment #5

bernardm28 commented 15 October 2021 at 04:10

Swapped hidden for visually_hidden.

Comment #6

greg boggs

he/him

English

Portland Oregon

commented 15 October 2021 at 15:59

Visually hidden is for elements that we want to retheme as things like buttons or logo links, but that we want visible to screen readers. In this case, I believe we want hidden.

Docs:

https://www.drupal.org/docs/accessibility/hide-content-properly

Comment #7

bernardm28 commented 18 October 2021 at 03:01

Status:

Active

» Needs review

Comment #8

bernardm28 commented 18 October 2021 at 03:02

Interesting, tks for the insight. It's a complicated topic for sure.

Comment #9

mglaman

English

WI, USA

commented 18 October 2021 at 15:15

I think we just want the block to not have the title displayed. Let's merge https://git.drupalcode.org/project/simplytest/-/merge_requests/100. That's the default checkbox value and I forgot to uncheck it.