Meeting Agenda

  1. Introductions
  2. Status and what's next
  3. Issue updates and discussion
  4. Where can people help this week?

Meeting Details

Time: 2pm UTC (10am Eastern)
‬Meeting Location: #olivero channel on drupal.slack.com

Meeting Notes

Hello, welcome to this week’s Front-end theme Olivero meeting!• This meeting happens every other Monday at 2pm UTC (10am ET)• There is no audio or video -- this meeting is chat only• The conversations for this meeting happen in threads0️⃣ If you’re attending this meeting, please let us know here. The meeting agenda is on d.o: #3242507: Olivero Meeting 2021-10-25

mherchel :wave:
Andy :pikachu_wave:
thejimbirch Good morning from Massachusetts!
Sarah Corbine Good morning
starshaped (she/her) Good morning, also from Massachusetts :slightly_smiling_face:
cathwaldron Good morning from Massachusetts
gaurav mahlawat Hello :wave:
shaal Hello :blob_wave:
Shefali Hello! Shefali from the Promote Drupal initiative :wave:

1️⃣ Status and what's nextThis tread is for discussing the overall status of the Olivero initiative and where we're going in broad terms. We'll save specific issue discussions for later threads.The META issue is here: #3177296: [META] Make Olivero stable

mherchel (composing response)
mherchel The last remaining issues (testing issues) for Olivero are being done (I literally just got done recording Opera Mini). Thanks to all who are helping out.
mherchel The goal is to move to stable as soon as these are done.
mherchel There was a couple issue identified (new and one existing). All except one are IE11 and pretty easy to fix (IE does not make display: block by default).
mherchel So, we’re continuing down that road ,and then will concentrate on making it the default

2️⃣ Individual issue discussion

mtift This thread is the place to bring up specific issues that need some extra discussion
mherchel This is an issue identified during IE testing (although it pertains to all browsers). Would love to get a review on it. #3244621: Olivero: JS error when secondary tabs are present
cathwaldron @mherchel I am new at this but would like to help. I could not reproduce this error in my iPhone Safari browser with multiple tabs open. Should I try the demo site in different browsers until I can reproduce this error, then use dev tools to step through the JS code to understand why it is throwing the error? I apologize if this is too basic a question.
mherchel @cathwaldron thanks for looking in to it! You can see the issues at https://tugboat-aqrmztryfqsezpvnghut1cszck2wwasr.tugboat.qa/tabs. You’ll probably want to use a desktop browser as debugging in IOS Safari is a pain. But it’s easy enough to see in Chrome.Note that I have a patch attached, too, so you’ll want to make sure you can reproduce the issue (by having secondary tabs visible) and then making sure the error doesn’t happen when the patch is applied
cathwaldron @mherchel Okay I will work on that today. Should I click the create issue fork button as prompted in the Drupal.org page for this issue even though I will just be testing the patch?
mherchel No… the code is already available in the patch (the fork and the patch are two different ways of doing the same thing). You’ll want to review the code and make sure it makes sense. If you’d like, I can create a Tugboat preview with the patch applied, so you don’t need to apply the patch yourself.
cathwaldron @mherchel That would be awesome, I know how to edit composer.json to add the patch but have not done this in Tugboat. I have several computers of different vintages, OS, and browsers so I would be able to check the before and after patch and report results as comment on the issue, is that right?
mherchel Done! Just edited my comment to link to the tugboat preview. Ping me if you have any questions.
cathwaldron fyi delayed by unrelated event. Working on it now.
cathwaldron I see the js error on unpatched site, and error is absent on the patched site, in Chrome on Ubuntu, so that is good! I will check Firefox, Chrome and Edge on Windows browsers later this evening and will report via issue on Drupal.org.
cathwaldron @mherchel the patch does appear to fix the JS error. I tested on four browsers - Chrome on Windows 10, Chrome on Ubuntu, Firefox on Ubuntu, and Edge on Windows 10. Posted comment on the issue. I am new at this so any feedback if I could have made a better comment or worded something better, guidance appreciated. Also glad to help with more of these.
mherchel @cathwaldron Thanks for the review! Can you post some screenshots (with at least one browser), and then set the “status” field to RTBC (reviewed and tested by the community)?At that point, the patch is reviewed, and it’s up to the core committers to look at it and commit it to core.

3️⃣ Where can people help this week?

mtift Share your suggestions here
mherchel easy answer: We need help testing and reviewing the sub-issues in [#3173877]Please read the testing script before doing reviews. There’s a number of things on the testing site that we don’t support (namely when webform injects css)
gaurav mahlawat needs review #3196976: Update .visually-hidden class
Shefali Hello! I'm not quite sure if my point fits well in this topic :face_with_rolling_eyes: but your inputs can really help us in our marketing efforts for your initiative. I represent the Promote Drupal initiative and as part of creating marketing materials, we are in the process of creating logos for each initiative. For that, we need your inputs and thoughts on it for your initiative. It would be great if you could submit your thoughts through this survey https://forms.gle/s3jswDjv6sv4hzrh8   Thank you! :slightly_smiling_face:

Participants:

mherchel, mtift, cathwaldron, gaurav mahlawat, Shefali

Comments

mtift created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented

Attended.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented

Attended

mtift credited Shefali.

mtift credited cathwaldron.

mtift credited mherchel.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
commented
Issue summary: View changes
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.