[D9] NTH Mobile

Thank you for applying!
Only reviews for other Drupal.org security advisory coverage applications are relevant for us.

• What follows is a quick review of the project; it doesn't mean to be complete
• For every point, the review doesn't make a complete list of lines that should be fixed, but an example of what is wrong in the code
• A review is about code that doesn't follow the coding standards, contains possible security issue, or doesn't correctly use the Drupal API; if a point isn't about that, it makes it clear

  /**
   * The entity type manager.
   *
   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
   */
  protected $entityTypeManager;

That property is already defined from the parent class; there is no need to define it again.

nth_mobile.admin_config:
  path: '/admin/config/services/nth-mobile'
  defaults:
    _title: 'NTH Mobile'
    _controller: '\Drupal\system\Controller\SystemController::systemAdminMenuBlockPage'
  requirements:
    _permission: 'administer nth_mobile configuration'

What is supposed to show, that route? It seem the route for the settings form, but it doesn't have any associated form.

    $entity = \Drupal::entityTypeManager()
      ->getStorage('nth_mobile_psms_transaction')
      ->load($data->retryMessageRef);

Classes that implement ContainerFactoryPluginInterface don't use \Drupal.

Added PAReview link: http://pareview.net/r/488

@tim-diels before I go fully in the review mode can you please help me with something ?
Does this payment gateway need the Commerce module or any other E-commerce module?
Because I cannot see how you log the payment statuses. Also without any e-commerce module I fail to see the use case here.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.