Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
Core migration issues
Next video meeting 2022-13-01 2100Z
The hope is that most or all of the maintainers will attend. We will try to focus on longer-term goals than in the weekly meeting.
Add agenda items
0️⃣ Who is here today?
| alison | Hi, Alison here! -- incoming shameless plugs:Drupal GovCon is underway! Registration is free and you can join now for today and tomorrow -- here's the session schedule -- things start at 11am EDT:https://www.drupalgovcon.org/2021-scheduleTomorrow there's a session on migrating paragraphs! https://drupalgovcon.sessionize.com/session/279846(I hear there are even spots left at some free trainings, though I don't know which ones so you'll just have to click thru to each Eventbrite.)TO JOIN, just click the "Get Your Hopin Ticket" banner at the top of the Drupal GovCon website :sonic: |
| benjifisher | Are there any sessions related to migrations?I am not planning to attend any camps until DrupalCamp NYC, two weeks from tomorrow. https://2021.drupalcamp.nyc/sessions#sz-session-287755 |
| benjifisher | I see that @dinarcon also has training lined up for NYC, the day after my session. |
| alison | Yes @dinarcon did a training yesterday!There's the paragraphs migration session I mentioned in my way-too-long-for-a-shameless-plug message above :D |
| benjifisher | Oops, I missed that. |
| mikelutz (he/him) | Checking in late :slightly_smiling_face: |
| quietone | Catching up |
1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today's meeting.
| alison | I wonder if maintainers have thoughts about participating in Hacktoberfest? -- looking at my own module, I can't figure out if we can add the "hacktoberfest" topic to an entire project, but maintainers should be able to add the "hacktoberfest-accepted" label to MRs -- if they wish. (Could wait til users ask, or could add to all new MRs -- only MRs opened in October are eligible.)Warning: This year's FAQ page is... frustrating to use...https://hacktoberfest.digitalocean.com/faq (edited) |
2️⃣ Action items. To be added later.
| benjifisher | Publish recording of the 2021-10-07 meeting. @benjifisher |
3️⃣ Statistics
| benjifisher | Fixed since last week's meeting: 2, including 1 Critical (not counting the issue for the meeting). |
| benjifisher | RTBC: 10, 1 of which is Major and 2 have been waiting for more than a month. |
| benjifisher | NR: 41, including 4 Major and 12 that have not been updated in more than three months. |
| benjifisher | Google sheet for recording stats: https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi... |
4️⃣ Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...
5️⃣ Previous minutes.
| benjifisher | Is there anything to follow up? Anything need to be changed in those minutes? |
| benjifisher | Last week's meeting was the quarterly Zoom meeting. I have the recording, but I need to trim the informal discussion from the start and end before making it public. |
| benjifisher | Minutes from the meeting 2 weeks ago: #3238927: [meeting] Migrate Meeting 2021-09-30 |
| benjifisher | I just read through the minutes. We moved along a lot of issues!I added 8️⃣ in today's meeting as a follow-up.I am marking the issue RTBC. |
| benjifisher | ... or maybe straight to Fixed. |
| quietone | Yes, if there are no requests to alter the previous minutes they can be set to fixed, no need for RTBC. |
6️⃣ Drush, migrate_tools, and migration groups
| benjifisher | @heddn, you shared the roadmap with the other Migrate maintainers. Can we share it in this channel? |
| heddn | @benjifisher absolutely. |
| benjifisher | Roadmap: https://docs.google.com/document/d/16KrsMGuYkPbG23hdpBMD6vGJZ13zT5GIBliD... |
| benjifisher | Must have in next major version of contrib modules
Nice to have
|
| benjifisher | I need clarification about "next major version".migrate_tools is currently 5.0. So we release 5.1 overriding the core Drush migration commands for BC and the Drush maintainers will update their composer.json so that it does not declare a conflict? |
| benjifisher | @marvil07 and I were working under the assumption that we would make 6.x BC and compatible with Drush 10.4+, then make further changes in 7.x. |
| benjifisher | I have not thought about how to support the !include tag. It might not be easy.Side note: I keep reminding myself that this is not the dreaded !important modifier from CSS. :wink: (edited) |
| benjifisher | Does the roadmap allow for reopening my Drush PR? Or do I still have to do it all in migrate_tools (for the BC version)? |
| benjifisher | I still wonder whether anyone uses both --tag and --group to provide independent filters for their migrations. |
| mikelutz (he/him) | Moshe did reopen your PR |
| miststudent2011 | We are currently handling a website with large data. And we are continuously using --tags to filter migrations. So it is useful when you deal with larger set of migration definitions. (edited) |
| miststudent2011 | And also if you don't have tags or groups. When running just drush ms command will throw error about Missing tables in source database. As it will look for D6 databases as well. |
| dinarcon | Thanks for sharing the roadmap. Is there a timeline for when work will start? Are there any pre-requisites like getting Drush 10.4+ compatibility first? |
| benjifisher | Work has started. |
| benjifisher | The migrate commands in Drush core do not support --group to limit the migrations. They do support --tag and will continue to support it. The Drush maintainers do not think there is a need for two mechanisms to limit the list. |
| benjifisher | I suggested a use case, but it is purely hypothetical. Have groups for your different sources and tags for your destinations. Then you might usedrush mim --group=some_d7_site --tag=blogand drush mim --group=atom_feed --tag=article
AFAIK no one actually finds this useful. |
| benjifisher | See the API docs for hook_migration_plugins_alter() for how to filter out the D6 migrations. |
| dinarcon | Oh, ok. I was asking about the changes about using !include as that would be a breaking change. I guess adding back compatibility with Drush 10.4+ can happen in parallel. |
| benjifisher | I think that compatibility with current Drush goes in ASAP. Yes, !include is a breaking change ... removing groups even more so ... and so we are targeting that for the next major version. |
7️⃣ Hacktoberfest (edited)
| benjifisher | https://hacktoberfest.digitalocean.com/faq |
| alison | I gotta drive but I'll be back asap! Sorry for the timing and thank you!! |
| alison | So I wonder if maintainers have thoughts about participating in Hacktoberfest? -- looking at my own module, I can't figure out if we can add the "hacktoberfest" topic to an entire project, but maintainers should be able to add the "hacktoberfest-accepted" label to MRs -- if they wish. (Could wait til users ask, or could add to all new MRs -- only MRs opened in October are eligible.) (edited) |
| benjifisher | I have not thought about it. What is the benefit of participating: does it give us more visibility? swag? attract volunteers? |
| alison | So, not really more visibility, at least not this year -- it's the first year GitLab projects are eligible, used to only be GitHub. BUT, as someone who's participated in Hacktoberfest for several years, it definitely motivates me to contribute to projects -- you can bet I'll be poking around to see where I might be able to submit MR's on Drupal projects, if I know the maintainer will be willing to give me hacktoberfest credit lol |
| alison | So maybe it would be a motivator for people already in the Drupal community to make some contributions this month.
Unfortunately, it has to be a MR that was created in October, so updates/improvements to existing MRs don't count. But still, I think it's mostly all upside, no downside -- unless we attract bad-faith "I want that t-shirt" MR activity, but I don't think we would, not the first year anyway. |
| alison | I think supporting contributors by way of Hacktoberfest could lead to more visibility and attract volunteers in the future, but maybe not this year (especially since I forgot about it 'til mid-October this year) -- but, gotta start sometime, and the first year we do it prob won't be super active no matter what, unless DA gets involved -- and I don't think all maintainers will want to participate anyway, especially people who also maintain GitHub projects that have been spammed in the past. |
| alison | I hope that helps, lmk if you have any other questions! |
8️⃣ ContentEntity source plugin shouldn't throw exception when the bundle key is missing: unavoidable in rollback situations
| benjifisher | #3186449: Rolling back a migration implementing MigrationWithFollowUpInterface does not clear the generated follow up migrations from the cache. |
| benjifisher | Can we get this issue back to RTBC? It was RTBC, but then other changes made it so the patch no longer applied. Two weeks ago, @danflanagan8 re-rolled the patch and removed a failing test case:
Before the conflict, the patch was passing tests. Was the failing test case added by the same issue that introduced the merge conflict? We need someone to confirm the re-roll and removing the test case. |
| danflanagan8 | The merge conflict happened because several tests were moved to a new test class. One of the relocated tests was the one that is changed in the issue here. So in essence the test existed in two places, with one version being outdated. |
| benjifisher | That means it is a legitimate part of the re-roll. |
| danflanagan8 | That's what I think, otherwise I wouldn't have done it. But sometimes I don't think too good. |
| benjifisher | What, you are only human? :wink:This is why all patches need review. |
| danflanagan8 | We can't all be pigs, right? |
Participants:
alison, benjifisher, quietone, heddn, mikelutz (he/him), miststudent2011, dinarcon, danflanagan8
Comments
Comment #2
quietone commentedApprove minutes from two weeks ago, #3238927: [meeting] Migrate Meeting 2021-09-30
Comment #3
quietone commentedDo we have a recording of this meeting? #3206778: [meeting] Migrate Meeting 2021-04-08 It would be good to be able to close that.
Comment #11
quietone commentedComment #12
quietone commentedReady for review
Comment #13
benjifisherThe minutes look good to me, and I checked the list of participants. I am marking this issue Fixed.