Problem/Motivation

\Drupal\migrate_drupal_ui\Form\ReviewForm::prepareOutput() could pass NULL to explode - the cause of deprecation on PHP 8.1.

Steps to reproduce

Run core/modules/migrate_drupal_ui/tests/src/Functional/d6/MultilingualReviewPageTest.php on PHP 8.1

Exception : Deprecated function: unserialize(): Passing null to parameter #1 ($data) of type string is deprecated
Drupal\migrate_drupal_ui\Form\ReviewForm->prepareOutput()() (Line: 287)

Proposed resolution

Don't call formatTimeDiffSince() with NULL last check

- https://git.drupalcode.org/project/drupal/-/commit/67984922cc36c777a2f1c...
- https://git.drupalcode.org/project/drupal/-/commit/cc50ace18ed671ef212b3...

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3240959-2.patch950 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3240959-2.patch950 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

I wrote this fix as part of #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • larowlan committed cb32dca on 9.3.x 
    Issue #3240959 by andypost, alexpott: \Drupal\migrate_drupal_ui\Form\...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Committed cb32dca and pushed to 9.3.x. Danke!

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.