Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
\Drupal\migrate_drupal_ui\Form\ReviewForm::prepareOutput()
could pass NULL to explode
- the cause of deprecation on PHP 8.1.
Steps to reproduce
Run core/modules/migrate_drupal_ui/tests/src/Functional/d6/MultilingualReviewPageTest.php
on PHP 8.1
Exception : Deprecated function: unserialize(): Passing null to parameter #1 ($data) of type string is deprecated
Drupal\migrate_drupal_ui\Form\ReviewForm->prepareOutput()() (Line: 287)
Proposed resolution
Don't call formatTimeDiffSince()
with NULL last check
- https://git.drupalcode.org/project/drupal/-/commit/67984922cc36c777a2f1c...
- https://git.drupalcode.org/project/drupal/-/commit/cc50ace18ed671ef212b3...
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#2 | 3240959-2.patch | 950 bytes | andypost |
Comments
Comment #2
andypostComment #3
alexpottI wrote this fix as part of #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)
Comment #4
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #6
larowlanCommitted cb32dca and pushed to 9.3.x. Danke!
Comment #7
larowlan