Active
Project:
Drupal core
Version:
main
Component:
comment.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Oct 2021 at 03:29 UTC
Updated:
2 Oct 2021 at 04:33 UTC
Jump to comment: Most recent
CommentStorageHandlerInterface::getMaxThread, getMaxThreadPerThread and getChildCids really shouldn't be a public API
Deprecate them and move Comment::preSave and Comment::postDelete to the storage handler.
Mark the methods as protected.
Comments
Comment #2
andypostit will need to file contrib issues to remove 3 usages http://grep.xnddx.ru/search?text=getMaxThread&filename=
Comment #3
andypostgetChildCids()has own usage http://grep.xnddx.ru/search?text=getChildCids&filename=