Drupal Version

Drupal 9.2.6

Domain module version

8.x-1.x

Expected Behavior

Adding a domain content condition plugin.

Issue fork domain-3239835

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

netsliver created an issue. See original summary.

dqd’s picture

Status: Active » Postponed (maintainer needs more info)

Can you please elaborate more about what you expect or what was missing before? There is a sub module under domain access called domain access content. Did you have enabled it and is there something missing? I would like to read more in the issue description about what the attempt is here. Thanks for the report and the work on this patch.

netsliver’s picture

Yes,

I have activated the domain_(access)_content module, it is precisely on this one that I made the patch in order to create a condition plugin in order to use it in pathauto (or elsewhere) combine with the following patch https://www.drupal.org/project/pathauto/issues/3224916.

Example :
node type : article
pattern pathauto for domain 1 : article/[node:title]
pattern pathauto for domain 2 : news/[node:title]

netsliver’s picture

StatusFileSize
new60.49 KB
new42.45 KB
new75.9 KB
new34.62 KB

Pathauto patterns list:

Pattern actions:

Pathauto conditions list with the patch https://www.drupal.org/project/pathauto/issues/3224916:

Domain content condition with my patch:

netsliver’s picture

Sorry for french screeshot :)

dqd’s picture

Status: Postponed (maintainer needs more info) » Needs work

Thanks for your awesome details! +1 Very helpful. Feel free to join us in the #domain channel on Drupal Slack for further discussion. THis would help to create momentum on the whole progress. I will try my best with my French in the channel :-)

netsliver’s picture

StatusFileSize
new4.48 KB

Another patch with different id because conflict with original domain condition

tibezh made their first commit to this issue’s fork.

tibezh’s picture

Version: 8.x-1.x-dev » 2.0.x-dev
Assigned: netsliver » Unassigned
Status: Needs work » Needs review

I've prepared a MR with the Condition implementation where we don't have a node required (to have more flexibility).
Could smby to check, please?

mably made their first commit to this issue’s fork.

mably’s picture

Status: Needs review » Postponed (maintainer needs more info)

Hi everybody, sounds like a neat feature I'm willing to merge but I want to test it first.

How can I test this new feature on a fresh Drupal 11 instance with domain modules installed?

I do not see the Domain condition on the pathauto pattern edit form.

tibezh’s picture

Status: Postponed (maintainer needs more info) » Reviewed & tested by the community
StatusFileSize
new53.3 KB

Hey @mably

In my case, the condition plugin helps display page variants (via a Page Manager module) separately for specific domains.

I'm sure that other modules can use the same condition plugin in the same way.

Here is a screenshot - https://www.drupal.org/files/issues/2025-10-21/21_10_2025_00a0127ec239f0...

mably’s picture

Version: 2.0.x-dev » 3.x-dev
Status: Reviewed & tested by the community » Needs work

@tibezh not sure to understand why we need to combine an "active domain" condition with an "assigned domain" one.

It feels like we should rather use two different conditions. Mixing both seems like a very specific use case.

mably’s picture

Added a new submodule to Domain Extras to allow better integration with the Page Manager module: #3553994: Integration with the page_manager module.

It allows to use the default current domain condition with the Page Manager module, we were missing the current domain context injection.

tibezh’s picture

Hey @mably, I'm using 2.x version, so the patch/change is actual for me, but need to upgrade to 3.x
Also, thank you for the note about the Domain Extras module, will check.

I think we can close the issue as outtdated

mably’s picture

Title: Add Domain Content Condition » Add Domain Access Condition
mably’s picture

Status: Needs work » Needs review

  • mably committed 557ebb8e on 3.x authored by tibezh
    Issue #3239835 by netsliver, tibezh, mably: Add Domain Access Condition
    
mably’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.