Problem/Motivation

There's outdated TODO in \Drupal\Core\StreamWrapper\LocalStream::getDirectoryPath()

Steps to reproduce

  /**
   * Gets the path that the wrapper is responsible for.
   *
   * @todo Review this method name in D8 per https://www.drupal.org/node/701358.
   *
   * @return string
   *   String specifying the path.
   */
  abstract public function getDirectoryPath();

Proposed resolution

remove the todo

Remaining tasks

review, commit

User interface changes

no

API changes

no

Data model changes

no

Release notes snippet

CommentFileSizeAuthor
#2 3239831-2.patch542 bytesandypost

Comments

andypost created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review
StatusFileSize
new 3239831-2.patch542 bytes
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

@Dries asked that we review this given getDirectoryPath() and dirname() both exist in this class. But dirname() exists because that's part of the stream wrapper interface, and we are stuck with getDirectoryPath() now unless we go down a whole deprecation/BC route to change it, and I don't see a better name anyway - it returns the directory path that the wrapper is responsible for.

Therefore I think the @todo is OK to remove and no other changes need to be made here.

  • catch committed 0b3a4ce on 9.3.x 
    Issue #3239831 by andypost, longwave: Remove outdated todo in \Drupal\...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 0b3a4ce and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.