Problem/Motivation

\Drupal\views\Controller\ViewAjaxController() passes the result $request->request->get('view_args') to Html::decodeEntities() which will trigger a deprecation if a NULL is passed in.

Steps to reproduce

See test runs on #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)

Proposed resolution

Use an empty string as the default value.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3239313-2.patch926 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Parent issue: » #3220021: [meta] Ensure compatibility of Drupal 9 with PHP 8.1 (as it evolves)
StatusFileSize
new 3239313-2.patch926 bytes
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, I think the ternary is with it to save the extra decode call

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed a9de164 and pushed to 9.3.x. Thanks!

  • catch committed a9de164 on 9.3.x 
    Issue #3239313 by alexpott, larowlan: \Drupal\views\Controller\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.