InlineFrame declares iframe.png as default thumbnail but this image does not exist anywhere, so the media library displays iframe medias without any icon.
/admin/content/media.iframe.png but fails.)The module should either include the image or use an existing image from core.
I will submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | iframe.png | 4.98 KB | chrissnyder |
| #12 | iframe-trans.png | 4.87 KB | chrissnyder |
| #8 | media_iframe-add-icon-for-iframes_15282072_8.patch | 28.58 KB | jschref |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
prudloff commentedComment #4
peterwcm commentedtest is failing somehow
Comment #5
dpiShall we add an iframe image?
If so, please provide licensing information and ensure it is GPL compatible.
Closing MR and resetting issue as it is a different direction.
Comment #7
jschref commentedAdds an icon and install file to utilize it. Ref. https://www.drupal.org/node/2863992
Comment #8
jschref commentedAnnnnddddd.... we can update that with the correct issue number. :/
Also just as a note for the next guy:
https://github.com/cweagans/composer-patches/issues/172
Comment #11
chrissnyderThank you for your work on this JSchref!. I opened a MR with your changes from the patch and added an update hook for those that already have the module installed.
Comment #12
chrissnyderThe icon in the patch/MR is from https://iconoir.com/, which I belive has an open-source MIT license. If that is not GPL-compatible, we can replace it with one of the attached icons. The attached Icons i just created myself for this project so there should not be any licensing issue with them.
Comment #13
prudloff commentedI think the MIT licence is GPL compatible : https://directory.fsf.org/wiki/License:Expat
Comment #14
smustgrave commentedTried testing the MR but the icon is still missing. Tried applying the MR before installing the module.
Comment #15
smustgrave commentedEh maybe it's an issue with getting the image via applying as a patch. I downloaded the image directly from the MR and copied that over to my files directory and works now.
Comment #16
martygraphie commentedHello,
I confirm @smustgrave's last comment.
I can't apply the patch in MR #6, but if I retrieve the image and add it manually to the folder it works too.
I prefer the iframe.png image in comment #12, which is more explicit than the image in MR.
Comment #17
dpiThanks everyone for continuing to push this along.
Theres some code gripes, for which I'm happy to address myself.
My major concern (cue bikeshedding) is the icon as proposed doesn't really capture the concept of iframe.
It is much closer to something that would represent a popup, since it seems to have the Mac-like three dots a window would have. But as we know, iframes do not have a window frame.
Some thoughts for an iframe: box with address bar or scroll bar. Use some kind of HTML-concept as the box concents, like a _generic_ tag:
</>There's a variety of concepts, alongside the one proposed, found when using search on icon websites/image search.
Lets try to keep rounded-corners/stroke-width similar to that found in the default Drupal/CKE icons. Mono/uncolored is great.
Comment #18
smustgrave commentedI've asked one of our UX designers for an image as we are trying to use this on a new project.
Comment #19
smustgrave commented