Problem/Motivation

The testbot does not run ESLint on all files when any of the config files in core/.eslint* are changed. Therefore the testbot passes, when there are files that break on the rule change and the testbot should fail.

Proposed resolution

Change the core/scripts/dev/commit-code-check.sh so that ESLint checks all files when core/.eslint* is changed.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3238936

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave created an issue. See original summary.

nod_ opened merge request !1267

nod_ made their first commit to this issue’s fork.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Issue tags: +JavaScript
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Active » Needs review
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. It accomplishes the task at hand. We can open a follow-up to discuss running this if yarn.lock has changed running everything.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

opened #3239590: Run all code checks when third party dependencies are updated

larowlan made their first commit to this issue’s fork.

  • larowlan committed b3f9fff on 9.3.x authored by nod_ 
    Issue #3238936 by nod_: The testbot does not run ESLint on all files...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Thanks folks

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

Need to open a follow up for doing the same with style lint config file

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.