if page_cache module is disabled trying to access/save the settings form `/admin/config/system/eu-cookie-compliance/settings` would throw this error.

Looks like page cache dependency was introduced in #3236586

Attaching a patch to revert page cache module dependency.

CommentFileSizeAuthor
#2 reverts-page-cache-dependency-3238918-2.patch2.5 KBahmed_samir

Issue fork eu_cookie_compliance-3238918

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ahmed_Samir created an issue. See original summary.

ahmed_samir’s picture

ahmed_samir commented
Status: Active » Needs review
StatusFileSize
new reverts-page-cache-dependency-3238918-2.patch2.5 KB

svenryen made their first commit to this issue’s fork.

svenryen’s picture

svenryen commented

Thank you for the patch, @Ahmed_Samir.

The thing is, we still want the feature for the people who have page_cache enabled.

I have fixed this in a slightly different way and I'm pushing a new version right away. Thanks for spotting this!

svenryen opened merge request !39

  • svenryen committed d81dd8c on 8.x-1.x 
    Issue #3238918 by svenryen, Ahmed_Samir: ServiceNotFoundException: You...
svenryen’s picture

svenryen commented
Status: Needs review » Fixed
svenryen’s picture

svenryen commented

Here's a link to the patch file, for reference:

https://git.drupalcode.org/project/eu-cookie-compliance/-/merge_requests...

svenryen’s picture

svenryen commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.