Updated core version requirement.

CommentFileSizeAuthor
#7 cloudfront_edge_caching-add-core-version-requirement-support-for-drupal-9-3238697-7.patch2.94 KBmogtofu33
#5 cloudfront_edge_caching-add-core-version-requirement-support-for-drupal-9-3238697-5.patch381 bytessouhaibhmam
#4 3238697-3.patch0 bytessourabhjain

Issue fork cloudfront_edge_caching-3238697

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

souhaibhmam created an issue. See original summary.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: Unassigned » sourabhjain
Issue summary: View changes

I am working on this issue.

souhaibhmam’s picture

souhaibhmam commented
Assigned: sourabhjain » souhaibhmam
Issue summary: View changes
StatusFileSize
new cloudfront_edge_caching-add-core-version-requirement-support-for-drupal-9-3238697-0.patch379 bytes
sourabhjain’s picture

sourabhjain
Primary language English
commented
Assigned: souhaibhmam » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3238697-3.patch0 bytes

Ignore this comment. As souhaib have already provided the patch.

souhaibhmam’s picture

souhaibhmam commented
Assigned: Unassigned » souhaibhmam
Status: Needs review » Active
StatusFileSize
new cloudfront_edge_caching-add-core-version-requirement-support-for-drupal-9-3238697-5.patch381 bytes

I created a new patch as the first patch does not take the drupal.org packaging script changes into consideration.

souhaibhmam’s picture

souhaibhmam commented
Status: Active » Needs review
mogtofu33’s picture

mogtofu33 commented
StatusFileSize
new cloudfront_edge_caching-add-core-version-requirement-support-for-drupal-9-3238697-7.patch2.94 KB

Updated patch including rector changes from issue #3146731

KurtTrowbridge made their first commit to this issue’s fork.

KurtTrowbridge opened merge request !1

kurttrowbridge’s picture

kurttrowbridge
he/him
commented

I added a merge request that incorporates the patch from #7 (the patch alone didn't apply for me, since Composer now errors out with a conflict between Drupal 9 being installed and the initially-unpatched module requiring Drupal 8). It installed successfully for me, but I'll leave this as Needs Review for someone else to confirm as well. Thanks!

geoanders’s picture

geoanders commented
Version: 8.x-1.0 » 8.x-2.x-dev
Assigned: souhaibhmam » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.