Respect the submission guidelines above! Drupal.org issue forks cause additional work for the project maintainer!

Issue

Currently this module ships plugins (Spellcheck, Suggester and Terms), but without any schema definition for that.

Proposed resolution

Add schema definitions like core is doing for its conditions.

GitHub PR

Issue fork search_api_solr-3236773

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

saidatom created an issue. See original summary.

saidatom opened merge request !8

saidatom’s picture

saidatom
Location Lisbon
commented
Assigned: saidatom » Unassigned
Status: Active » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs review » Needs work

See the MR.

saidatom’s picture

saidatom
Location Lisbon
commented
Status: Needs work » Needs review
saidatom’s picture

saidatom
Location Lisbon
commented

GitHub PR

saidatom’s picture

saidatom
Location Lisbon
commented
Issue summary: View changes
dimilias’s picture

dimilias commented
Status: Needs review » Reviewed & tested by the community
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Reviewed & tested by the community » Needs work

We already discussed the bad pattern of Search API Autocomplete to expect that a backend implements a "virtual" interface that doesn't really exist. That's even a bigger issue and not noted here. I think that the right solution would be to create the AutocompleteInterface within Search API.

For the issue here we should move Solr's autocomplete plugins into a search_api_solr_autocomplete sub-module that depends on search_api_autocomplete. And the schema from the current patch has to be moved there.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Needs work » Reviewed & tested by the community

Development is done here https://github.com/mkalkbrenner/search_api_solr/pull/73

All remarks were addressed. RTBC

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

[comment removed]

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Reviewed & tested by the community » Needs work

The tests fail: https://github.com/mkalkbrenner/search_api_solr/actions/runs/1583107311

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

@mkalkbrenner, we cannot fix tests as we cannot trigger them. Just waiting for the maintainer to run them is not productive.

  • ceb2211 committed on 4.x 
    Issue #3236773 by saidatom, claudiu.cristea, mkalkbrenner, idimopoulos:...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Fixed

Thanks for your help with this!

I'll create a follow-up now to move the remaining autocomplete functionality into the new sub-module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mkalkbrenner closed merge request !8