-entity: Entity the comments are attached to.

https://git.drupalcode.org/project/drupal/-/blob/9.2.6/core/modules/comm...

In fact the variable name is commented_entity
https://git.drupalcode.org/project/drupal/-/blob/9.2.6/core/modules/comm...

Issue fork drupal-3236540

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Chi created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Closed (works as designed)
Issue tags: +Bug Smash Initiative

Comment and commented entity are two different things, the later is the entity to which the comment is attached, e.g a node

If that's not what you're seeing, please reopen

chi’s picture

chi commented
Issue summary: View changes

Sorry, the quote was referencing wrong variable. The issue is about entity and commented_entity variables. I've just fixed the issue description.

chi’s picture

chi commented
Status: Closed (works as designed) » Active

gabrielda made their first commit to this issue’s fork.

gabrielda’s picture

gabrielda
He/Him
commented
Assigned: Unassigned » gabrielda

gabrielda opened merge request !1291

gabrielda’s picture

gabrielda
He/Him
commented

Hello,

I have changed the documentation as suggested. Please review.

Cheers,
Gabriel

gabrielda’s picture

gabrielda
He/Him
commented
Assigned: gabrielda » Unassigned
Status: Active » Needs review
chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community

Thank you.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work

We should also update other instances of comment.html.twig.

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues

I'm planning to work on this issue by today. Monday too, probably. I'm new here, so it's my first time working on a issue. Hopefully, I will send it to review soon.

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned
Status: Needs work » Needs review

Fixed the documentation in the others files too.

chi’s picture

chi commented

@beatrizrodrigues the failed test checks MD5 hash for the comment.html.twig temlate. Since the content of the file has been changed it needs to be updated. The new hash is 7662f597b7d22817b156d1e2956e6b84.
https://git.drupalcode.org/issue/drupal-3236540/-/blob/3236540-wrong-doc...

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented

@chi thank you! I did it.

chi’s picture

chi commented
Status: Needs review » Needs work

The name of the variable is "commented_entity" not "commented-entity".

ankithashetty made their first commit to this issue’s fork.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review

Updated variable name from 'commented-entity' to 'commented_entity' as suggested in #16 and rebased the branch.

Thanks!

chi’s picture

chi commented
Status: Needs review » Needs work

The file hash needs to be updated once again.

beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: Unassigned » beatrizrodrigues
beatrizrodrigues’s picture

beatrizrodrigues
She/Her
commented
Assigned: beatrizrodrigues » Unassigned
Status: Needs work » Needs review

I think it will be all fixed right now.

chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Thank you.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ec2c23d and pushed to 9.3.x. Thanks!

  • alexpott committed ec2c23d on 9.3.x 
    Issue #3236540 by beatrizrodrigues, gabrielda, ankithashetty, Chi,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.