Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::atPath()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setParameter()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setParameters()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setTranslationDomain()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setInvalidValue()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setPlural()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setCode()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Method "Symfony\Component\Validator\Violation\ConstraintViolationBuilderInterface::setCause()" will return "static" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ConstraintViolationBuilder" will be required when upgrading.
Steps to reproduce
Proposed resolution
Add return type hints.
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3233479-6-10.0.x.patch | 4.57 KB | longwave |
| |||
| #2 | 3233479-2.patch | 2.37 KB | daffie |
Comments
Comment #2
daffie CreditAttribution: daffie commentedThis patch has to wait for the 10.0 branch as the "static" return type hints is only supported on PHP version 8.0.
Comment #3
daffie CreditAttribution: daffie commentedComment #4
longwaveWe have deprecated ConstraintViolationBuilder for removal in 10.0.x but as we are upgrading to SF5.4 for alpha1 without removing deprecations, I think we have to commit this first to make the deprecation listener happy and then remove it later.
Comment #5
catchNeeds a re-roll for 10.0.x
Comment #6
longwaveRerolled.
Comment #7
catchRe-roll looks fine back to RTBC.
Comment #9
catchCommitted e4f1b9c and pushed to 10.0.x. Thanks!