Problem/Motivation

This problem was found by @rkoller, thanks!

after the update successfully applied according to the admin notice "update complete!" i see again the view (see screenshots automatic-update.png) from before stating that the installed version is 9.2.4 and the recommended version is 9.2.5. that ambigious messaging unsettled me as a user. on one hand the update to 9.2.5 was successfully completed according to the admin notice on the other hand the installed version is still 9.2.4 is confusing - whom to trust on this page? ;)

#3232761: Create local task links to the updater form might slightly change this but we still need to clear the update status the user will see that they have successfully update. Clearing it will mean on "Available Updates" and other places they will see the correct status.

Proposed resolution

Currently, this seems to work, since our batch processor redirects to the update.status route and therefore refreshes the update info. However, we have no test coverage of it. So let's at least make sure this continues to work.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

tedbow credited rkoller.

tedbow’s picture

tedbow’s picture

Issue summary: View changes

phenaproxima made their first commit to this issue’s fork.

phenaproxima’s picture

Status: Active » Needs review

I'm not super happy with this solution, but the Update module frankly makes my life harder with its aggressively bizarre API.

Having UpdateRecommender clear the stored data seems reasonable enough, but it means we'll always be checking for updates (for every installed project, no less, not just core) every time the updater form loads, and every time the cron handler runs. That's not awesome.

What I'd prefer is if core had some API for clearing the stored data for a single, specific project. That, I think, makes sense as something an automatic update system would want to refresh on the regular. But I can't see anything like that in the Update module as it currently exists. Either I've missed something, or this is something that should be fixed in core.

phenaproxima’s picture

Title: Clear update status after an update is applied » Test that update status is cleared after an update is applied
Issue summary: View changes
phenaproxima’s picture

  • phenaproxima committed d143bfc on 8.x-2.x
    Issue #3233124 by phenaproxima, tedbow, rkoller: Test that update status...
phenaproxima’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.