If I'm reading the code correctly, the default submission interval is 86400 * 60 * 60 = 311,040,000 seconds = nearly 10 years.
This... is too long.

From simple_sitemap_engines.module:

function simple_sitemap_engines_cron() {
  $config = \Drupal::config('simple_sitemap_engines.settings');

  if ($config->get('enabled')) {
    $interval = (int) $config->get('submission_interval') * 60 * 60;
    $request_time = \Drupal::time()->getRequestTime();

From simple_sitemap_engines.settings.yml

enabled: true
submission_interval: 86400

I think the * 60 * 60 bit should probably be eliminated, so that the submission interval can be specified in seconds as expected, right?

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

AaronBauman created an issue. See original summary.

aaronbauman’s picture

Status: Active » Needs review

  • gbyte committed bca9728 on 4.x
    Issue #3233116 by gbyte, AaronBauman: Default submission interval is too...
gbyte’s picture

Status: Needs review » Fixed

Thanks for catching this! Adhering to the main module's logic, it appears the problem is the actual value which should be the amount in hours, not seconds. I just changed the value and added an update hook for all the poor souls which left this at default. ;)

gbyte’s picture

Component: Code » Code: Search engine integration

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.