umami: warning message has no left-right spacing when admin toolbar module is installed.

Adding screenshot for reference.

CommentFileSizeAuthor
#3 After Patch 3233044.png705.15 KBchetanbharambe
#3 Before patch 3233044.png693 KBchetanbharambe
#2 3233044-2.patch527 bytesgauravvvv
Screenshot 2021-09-15 at 3.49.49 PM.png23.23 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3233044-2.patch527 bytes

patch attached, please review.

chetanbharambe’s picture

chetanbharambe commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before patch 3233044.png693 KB
new After Patch 3233044.png705.15 KB

Verified and tested patch #2.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: Umami demo on 9.3.x-dev version
# Goto: Appearance: Apply Umami Theme
# Goto: admin/content page
# User will see a warning message above the toolbar

Expected Results:
# There should be some margin before the warning message when the admin toolbar module is installed.

Actual Results:
# Warning message has no left-right spacing when admin toolbar module is installed.

Please refer attached screenshots for the same.
Looks good to me.
Can be a move to RTBC.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Is this something that the admin toolbar module could handle given that this can be only reproduced with a contrib module?

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative

Closing as cannot reproduce

Did a fresh install of Umami on D9.5
Install admin toolbar search and am seeing space between the two

To answer #4 if this is still an issue I believe it should be opened under admin_toolbar.