Problem/Motivation

Method "Symfony\Component\Routing\Matcher\UrlMatcherInterface::match()" will return "array" as of its next major version. Doing the same in implementation "Drupal\Core\Routing\AccessAwareRouter" will be required when upgrading.

Method "Symfony\Component\Routing\Matcher\UrlMatcherInterface::match()" will return "array" as of its next major version. Doing the same in implementation "Drupal\Core\Routing\AccessAwareRouterInterface" will be required when upgrading.

Method "Symfony\Component\Routing\Matcher\UrlMatcherInterface::match()" will return "array" as of its next major version. Doing the same in implementation "Drupal\Core\Routing\Router" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add the "array" return type hint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3233041-2.patch1.74 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
3233041-2.patch1.74 KB

The fix.

daffie’s picture

daffie CreditAttribution: daffie commented

I could not find any instances where the method is overridden in contrib. See: http://grep.xnddx.ru/search?text=public+function+match%28%24pathinfo%29&....

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce commented
Status: Reviewed & tested by the community » Fixed

Committed 61b7e46 and pushed to 9.3.x. Thanks!

  • alexpott committed 61b7e46 on 9.3.x 
    Issue #3233041 by daffie: [Symfony 6] Add "array" type hint to methods...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.