Problem/Motivation

The tests won't pass in drupal.org because ForcePasswordChangeBrowserTestBase.php is a test class with help methods only.
The solution is to create a trait with the methods or make that class an abstract class.

As in ForcePasswordChangeBrowserTestBase class are only help methods, the right thing to do is to convert it to a trait.

CommentFileSizeAuthor
#13 3232926-13.patch16.9 KBlarisse
#12 3232926-12.patch17.62 KBlarisse
#11 3232926-11.patch17.62 KBlarisse
#10 3232926-9.patch519 byteslarisse
#8 3232926-8.patch7.08 KBlarisse
#7 3232926-7.patch524 byteslarisse

Issue fork force_password_change-3232926

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paulocs created an issue. See original summary.

paulocs opened merge request !6

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Needs work
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Needs review
paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Merged 2.0.x into 3232926-make-forcepasswordchangebrowsertestbase-a

larisse’s picture

larisse commented
Status: Needs review » Needs work
StatusFileSize
new 3232926-7.patch524 bytes

In #3233059: Test issue - Do not commit, we can see that it's still needs work.
I'm applying this patch to see if tests will pass.

larisse’s picture

larisse commented
StatusFileSize
new 3232926-8.patch7.08 KB

A new try...

larisse’s picture

larisse commented
Parent issue: » #3254813: Plan for Force Password Change
larisse’s picture

larisse commented
StatusFileSize
new 3232926-9.patch519 bytes
larisse’s picture

larisse commented
StatusFileSize
new 3232926-11.patch17.62 KB
larisse’s picture

larisse commented
StatusFileSize
new 3232926-12.patch17.62 KB
larisse’s picture

larisse commented
StatusFileSize
new 3232926-13.patch16.9 KB

  • larisse committed 766a6d8 on 2.0.x 
    Issue #3232926 by larisse, paulocs: Make...
larisse’s picture

larisse commented
Status: Needs work » Fixed

The trait problem was solved, but we find a problem with one functional test.

I removed the Functional Test that cause memory problems...
Is a temporary solution, just to make the module OK to the new release, but I plan open an issue for work this later.

Thank you for help paulocs.

  • larisse committed b6e63d8 on 2.0.x 
    Issue #3232926 by larisse, paulocs: Make...

  • larisse committed 8662c90 on 2.0.x 
    Issue #3232926 by larisse, paulocs: Make...
larisse’s picture

larisse commented
Status: Fixed » Needs work
larisse’s picture

larisse commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

heddn closed merge request !6