Problem/Motivation

Getting the error mentioned below while migrating:

  [Drupal\Core\Database\DatabaseExceptionWrapper]                                             
  SQLSTATE[HY000]: General error: 1 no such table: agreement_type: SELECT COUNT(*) AS "expression"

Steps to reproduce

This problem occurs when an existing Drupal 7 site with agreement module is migrated to Drupal 9.

Proposed resolution

Use DrupalSqlBase instead of SqlBase class.

Remaining tasks

NA

User interface changes

NA

API changes

NA

Data model changes

NA

CommentFileSizeAuthor
#6 interdiff_2-6.txt2.88 KBsrishtiiee
#6 drupalsqlbase_instead_of_sqlbase-3232859-6.patch4.22 KBsrishtiiee
#2 drupalsqlbase_instead_of_sqlbase-2.patch1.34 KBsrishtiiee

Comments

srishti.bankar created an issue. See original summary.

srishtiiee’s picture

srishtiiee commented
Issue summary: View changes
StatusFileSize
new drupalsqlbase_instead_of_sqlbase-2.patch1.34 KB
narendrar’s picture

narendrar
He/Him
Primary language English
Location Jaipur, India
commented
Status: Active » Needs review
Related issues: +#3231034: Use DrupalSqlBase instead of SqlBase class

Status: Needs review » Needs work

The last submitted patch, 2: drupalsqlbase_instead_of_sqlbase-2.patch, failed testing. View results

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Version: 8.x-2.1 » 8.x-2.x-dev

Thank you for the patch.

It looks like the tests are failing due to changing the test class. I checked the current 8.x-2.x and 3.0.x branches, which both pass tests. So probably need to update both the test classes to account for the test failures. Would you be able to do that, @srishti.bankar?

srishtiiee’s picture

srishtiiee commented
Status: Needs work » Needs review
StatusFileSize
new drupalsqlbase_instead_of_sqlbase-3232859-6.patch4.22 KB
new interdiff_2-6.txt2.88 KB

Uploaded new patch with updated fixtures within tests.

  • mradcliffe committed d0402d4 on 3.0.x 
    Issue #3232859 by srishti.bankar, narendraR: Changes migrate source...

  • mradcliffe committed a74efe9 on 8.x-2.x 
    Issue #3232859 by srishti.bankar, narendraR: Changes migrate source...
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Fixed

Thank you!

This looks good to me. Committed to 8.x-2.x and cherry-picked to 3.0.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.