Problem/Motivation

The \Drupal\tfa\Form\TfaLoginForm::loginWithoutTfa method renders a message which starts with

You are required to setup two-factor authentication <a href="@link">here.</a>

Linking the word "here" is an accessibility problem and violates WCAG criterion 2.4.9.

Proposed resolution

Rewrite the sentence like this:

You are required to <a href="@link">setup two-factor authentication</a>.

Remaining tasks

When fixing this issue, please give credit to marloes_bosch who noticed the problem.

Issue fork tfa-3232850

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

marcvangend created an issue. See original summary.

marcvangend opened merge request !6

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
jeremyr’s picture

jeremyr commented
Status: Needs review » Reviewed & tested by the community

I agree with the requested change here and the change is so very minor.

Tested applying the MR as a patch and it applied cleanly. Does exactly what I expected and as a result marking as RTBC.

jcnventura made their first commit to this issue’s fork.

jcnventura’s picture

jcnventura
Primary language English
commented
jcnventura’s picture

jcnventura
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I apologize, @jeremyr for not mentioning you in the commit, it was a side-effect of making sure to credit @marloes_bosch as requested in the IS.

jeremyr’s picture

jeremyr commented

No hurt feelings here.

marcvangend’s picture

marcvangend
he/him
Primary language Dutch
Location Amsterdam
commented

Thanks all for the quick follow up!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.