In \Drupal\salesforce_pull\Controller\PullController::populateQueue (line 172), the parameter passed to loadByProperties is wrapped in double brackets / nested array, I think only one set of bracket is needed.
else {
$mappings = $this->mappingStorage->loadByProperties([["pull_standalone" => TRUE]]);
}
--------------------------------------
p.s. This is my first post, so apologies if I am not doing this correctly. I looked through the existing issue queue, and cannot find one similar.
| Comment | File | Size | Author |
|---|---|---|---|
| salesforce_pull_controller.patch | 549 bytes | Edith.F |
Comments
Comment #3
aaronbaumanGreat, thank you for filing the issue, definitely a bug.
I've committed it to the dev versions of both 5.0.x and 8.x-4.x
Congratulations on filing your first patch!
I hope I'm not over-stepping by offering a couple points of feedback so you can continue to file successful patches:
This will not only trigger any automated tests, but also bring the issue to maintainers attention
Where you have:
Should be:
I'm guessing this is because salesforce module is included in your site's repository, rather than a standalone clone of the module repo. Generally, you want to avoid editing patch files by hand, but it's relatively safe to edit the file paths.
Thanks again!
PS. if you haven't already, take a look at cweagans/composer-patches which will help you manage patches on your site.
Comment #4
Edith.F commentedHi Aaron,
Your feedback is greatly appreciated!
It is a bit intimidating using the issue queue the first time around. So, thank you for taking the time to reply.
Comment #5
aaronbaumanYou're welcome, no problem at all.
The patch system is very Drupal-specific and intimidating, I agree.
P.P.S If you're familiar with git and/or github, you may find it easier to use the Merge Request feature through gitlab, which works a bit like Pull Requests in github.