With SQL-based views, it's possible to define additional query tags to add to the view from the "Query settings" of the view. Currently, when editing a view based on a Search API index, this option isn't accessible, but it seems that the \Drupal\search_api\Query\QueryInterface supports the use of query tags.
Add support for the option to Search API Views.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3232736-12--views_custom_query_tags.patch | 5.87 KB | drunken monkey |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
guypaddock commentedComment #3
guypaddock commentedComment #4
guypaddock commentedLooking into this now.
Comment #6
guypaddock commentedI've submitted an MR to add this feature. This likely needs tests, but does work in manual testing.
Comment #7
guypaddock commentedThe MR includes changes from #3232745: Manually-added Query Tags in "Query Settings" are Lost when Changing Override Status of Query Options for any Display to avoid losing query tags when toggling the "override" state of a display.
Comment #8
drunken monkeyThanks a lot for reporting this, this does look like a good idea!
The code looks also sensible, except that I think
submitConfigurationForm()could be a lot more concise. Anyways, very good you already included the fix for this strange Core bug.You are right, though, this definitely still needs tests. Are you willing/able to provide some?
Unfortunately, due to #3190024: Problem with test dependencies when testing issue forks, we cannot really use MRs in this project yet. We’ll have to stick with patches until this is fixed.
Consequently, I’m attaching a patch with my changes. Please test/review to see if this still works for you.
Comment #9
drunken monkeyNW for the tests.
Comment #10
guypaddock commented@drunken monkey Your changes LGTM! Unfortunately, I have been having a lot of issues with getting any kind of testing working locally; it's on our team's list of tech debt to tackle so we can author tests but right now it's a blocker for me.
Comment #11
idebr commentedAttached patch adds a test that adds Query Tags through the Views UI and asserts the query tag is correctly added to the Search API query through
SearchApiEvents::QUERY_PRE_EXECUTE.TAGComment #12
drunken monkeyThanks a lot, great job!
I just changed a few details and will commit if the test bot is happy.
Comment #14
drunken monkeyCommitted.
Thanks again, everyone!