Problem/Motivation

The Unit tests are failing in HEAD.

Steps to reproduce

Run the tests

Issue fork force_password_change-3232363

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paulocs created an issue. See original summary.

paulocs opened merge request !5

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Active » Needs review
Related issues: +#3232195: Add $defaultTheme to Functional tests, +#3231237: Trigger tests on commit
gabriel.abdalla’s picture

gabriel.abdalla commented
Status: Needs review » Reviewed & tested by the community

Hi,

Changes of 3232363-fix-unit-tests looks good. There are other issues (standards, deprecation) that should be addressed in other issues, they are not related to the changes performed in this issue.

larisse’s picture

larisse commented
Status: Reviewed & tested by the community » Needs work

Hi! I run the tests, but I received this notice: 

Remaining self deprecation notices (9)

  9x: Declaring ::setUp without a void return typehint in Drupal\Tests\force_password_change\Unit\Service\ForcePasswordChangeServiceTest is deprecated in drupal:9.0.0. Typehinting will be required before drupal:10.0.0. See https://www.drupal.org/node/3114724
    9x in DrupalListener::startTest from Drupal\Tests\Listeners

Can you fix this, please?

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs work » Reviewed & tested by the community

As this is just a deprecation notice and does not interfere if the tests as passing or not, I'm moving the issue back to RTBC.

  • larisse committed d99ee87 on 2.0.x authored by paulocs 
    Issue #3232363 by paulocs, gabriel.abdalla, larisse: Fix Unit tests
larisse’s picture

larisse commented
Status: Reviewed & tested by the community » Fixed

Thank you all.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.