.bin/drupal-check docroot/modules/contrib/piwik

19/19 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ ---------------------------------------------------------------
Line piwik.install
------ ---------------------------------------------------------------
120 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage()
instead.
------ ---------------------------------------------------------------

------ -----------------------------------------------------------------------
Line piwik.module
------ -----------------------------------------------------------------------
118 Call to deprecated function drupal_get_messages():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::all() or
\Drupal\Core\Messenger\MessengerInterface::messagesByType()
instead.
181 Call to deprecated method strlen() of class
Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strlen() instead.
181 Call to deprecated method strlen() of class
Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strlen() instead.
441 Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0
and is removed from drupal:10.0.0. Use
\Drupal::time()->getRequestTime();
443 Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0
and is removed from drupal:10.0.0. Use
\Drupal::time()->getRequestTime();
500 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
502 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
502 Call to deprecated function file_unmanaged_save_data():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::saveData().
505 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
505 Call to deprecated function file_unmanaged_save_data():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::saveData().
516 Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
516 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
519 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
519 Call to deprecated function file_unmanaged_save_data():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::saveData().
522 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
522 Call to deprecated function file_unmanaged_save_data():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::saveData().
546 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
547 Call to deprecated function file_scan_directory():
in drupal:8.8.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
648 Call to deprecated method strtolower() of class
Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtolower() instead.
652 Call to deprecated method strtolower() of class
Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strtolower() instead.
------ -----------------------------------------------------------------------

------ -------------------------------------------------------
Line src/Form/PiwikAdminSettingsForm.php
------ -------------------------------------------------------
617 Call to deprecated method strlen() of class
Drupal\Component\Utility\Unicode:
in drupal:8.6.0 and is removed from drupal:9.0.0. Use
mb_strlen() instead.
------ -------------------------------------------------------

------ ------------------------------------------------------------------
Line src/Tests/PiwikBasicTest.php
------ ------------------------------------------------------------------
13 Class Drupal\piwik\Tests\PiwikBasicTest extends deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
33 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ ------------------------------------------------------------------

------ -------------------------------------------------------------------
Line src/Tests/PiwikCustomUrls.php
------ -------------------------------------------------------------------
13 Class Drupal\piwik\Tests\PiwikCustomUrls extends deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
26 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ -------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Tests/PiwikCustomVariablesTest.php
------ ----------------------------------------------------------------------
13 Class Drupal\piwik\Tests\PiwikCustomVariablesTest extends deprecated
class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
26 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ ----------------------------------------------------------------------

------ ----------------------------------------------------------------------
Line src/Tests/PiwikPhpFilterTest.php.php
------ ----------------------------------------------------------------------
13 Class Drupal\piwik\Tests\PiwikPhpFilterTest extends deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
26 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ ----------------------------------------------------------------------

------ ------------------------------------------------------------------
Line src/Tests/PiwikRolesTest.php
------ ------------------------------------------------------------------
13 Class Drupal\piwik\Tests\PiwikRolesTest extends deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
26 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ ------------------------------------------------------------------

------ -------------------------------------------------------------------
Line src/Tests/PiwikSearchTest.php
------ -------------------------------------------------------------------
12 Class Drupal\piwik\Tests\PiwikSearchTest extends deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ -------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line src/Tests/PiwikStatusMessagesTest.php
------ ---------------------------------------------------------------------
12 Class Drupal\piwik\Tests\PiwikStatusMessagesTest extends deprecated
class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ ---------------------------------------------------------------------

------ -----------------------------------------------------------------------
Line src/Tests/PiwikUninstallTest.php
------ -----------------------------------------------------------------------
12 Class Drupal\piwik\Tests\PiwikUninstallTest extends deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
54 Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
54 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
57 Call to deprecated function file_unmanaged_save_data():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::saveData().
58 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in
drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
58 Call to deprecated function file_unmanaged_save_data():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::saveData().
61 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
74 Call to deprecated function file_scan_directory():
in drupal:8.8.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
75 Call to deprecated function file_prepare_directory():
in drupal:8.7.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
------ -----------------------------------------------------------------------

------ ---------------------------------------------------------------------
Line src/Tests/PiwikUserFieldsTest.php
------ ---------------------------------------------------------------------
12 Class Drupal\piwik\Tests\PiwikUserFieldsTestTest extends deprecated
class Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
25 Call to method setUp() of deprecated class
Drupal\simpletest\WebTestBase:
in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
use \Drupal\Tests\BrowserTestBase. See
https://www.drupal.org/node/3030340.
------ ---------------------------------------------------------------------

------ -----------------------------------------------------------------
Line tests/modules/piwik_test/src/Controller/PiwikTestController.php
------ -----------------------------------------------------------------
20 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage()
instead.
21 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage()
instead.
22 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage()
instead.
23 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage()
instead.
------ -----------------------------------------------------------------

[ERROR] Found 52 errors

Issue fork piwik-3232158

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

SerShevchyk created an issue. See original summary.

sershevchyk’s picture

Status: Active » Needs work

vendor/bin/drupal-check web/modules/contrib/piwik
19/19 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors

So need to fix problems with tests

saphemmy’s picture

Assigned: Unassigned » saphemmy

Will fix problem with tests

saphemmy’s picture

Assigned: saphemmy » Unassigned

I suggest this issues should probably have child issues:

  1. For the Business logic
  2. For the tests

If not this will might be too big a patch to review after working on it

Tauany Bueno’s picture

Assigned: Unassigned » Tauany Bueno

hi! i'll work on it :)

Tauany Bueno’s picture

Assigned: Tauany Bueno » Unassigned
Status: Needs work » Closed (outdated)

Hello!
The Piwik module is outdated and was renamed to Matomo, so there's no need to fix the tests on this module. However, if the same issues happens on the Matomo module, i'd be happy to help in another issue :)