Problem/Motivation

#3228634: Move tests for integrations between QuickEdit and other modules into QuickEdit so that it can more easily be moved into contrib moved all known QuickEdit integration tests into the QuickEdit module, but we missed one method: Drupal\Tests\layout_builder\Functional\LayoutBuilderTest::testRemovingAllSections() still requires permission to use QuickEdit.

Proposed resolution

Move this method to a test in QuickEdit, and/or alter the test to decouple it from QuickEdit.

Remaining tasks

TBD

Issue fork drupal-3230928

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented

@longwave addressed this in #3227033: Remove Quick Edit from core by simply deleting this hunk:

    // Install Quick Edit as well.
    $this->container->get('module_installer')->install(['quickedit']);
    $this->drupalLogin($this->drupalCreateUser([
      'configure any layout',
      'administer node display',
      'access in-place editing',
    ]));

xjm credited dww.

xjm’s picture

xjm
she/her
Primary language English
commented

Oops, sorry, it was @dww -- @longwave just rebased that same commit. ;)

Spokje made their first commit to this issue’s fork.

Spokje opened merge request !1150

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Remove LayoutBuilderTest::testRemovingAllSections()' QuickEdit dependency » Remove unused LayoutBuilderTest::testRemovingAllSections()' Quick Edit dependency
Status: Needs review » Reviewed & tested by the community

Well … that was very simple :D

There already was no dependency, only an unnecessary use/mention. Great!

  • catch committed 19594b9 on 9.3.x 
    Issue #3230928 by Spokje, xjm, dww: Remove unused LayoutBuilderTest::...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed 19594b9 and pushed to 9.3.x. Thanks!

Spokje closed merge request !1150

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.