Closed (fixed)
Project:
Gamification
Version:
1.0.x-dev
Component:
Miscellaneous
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
1 Sep 2021 at 06:49 UTC
Updated:
11 May 2023 at 17:48 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
mohit.bansal623 commentedDid you left anything in that patch?
Comment #3
rajeshreeputrahello @mohit.bansal623,
Yes few things are still there which need to take care of, didn't getting enough time to work on those. Almost 80% to 85% of PHPCS issues are fixed in the provided patch.
Comment #4
sourabhjainResolved all the PHPCS issues. Please review.
Comment #5
hmendes commentedStill missing these errors when running phpcs
Comment #6
rajeshreeputraIt's been covered in the patch provided in the description.
@sourabhjain, could you please combine both the patches.
Thanks,
Rajeshreeputra
Comment #7
andregp commentedI'll combine the patches and check if anything else is missing
Comment #8
andregp commentedComment #9
andregp commentedI applied the patch from @sourabhjain to the code (which had less phpcs errors remaining) and made the remaining changes consulting @rajeshreeputra patch. Although, there was still two phpcs errors that neither of them addressed (from GamificationInterface.php and GamificationWidgetBase.php), but they were easy to fix.
Comment #10
anagomes commentedThe patch in #9 applies just fine, and corrects every error and warning pointed by PHPCS before the patch was applied.
Comment #11
avpadernoThe issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
Comment #12
avpadernoComment #13
indrapatil commentedComment #14
avpadernoComment #17
kunalgautam commentedComment #18
avpadernoThe status is also for the issue summary, which needs to be updated.
Comment #19
joaomarques736 commentedComment #20
joaomarques736 commented