Problem/Motivation

--------------------------------------------------------
FOUND 15 ERRORS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------------------------------------------------
65 | ERROR | [ ] Parameter $configuration is not described in comment
65 | ERROR | [ ] Parameter $plugin_id is not described in comment
65 | ERROR | [ ] Parameter $plugin_definition is not described in comment
67 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
252 | ERROR | [x] Missing function doc comment
258 | ERROR | [x] Expected 1 space after IF keyword; 0 found
356 | ERROR | [ ] Missing parameter comment
356 | ERROR | [ ] Missing parameter type
357 | ERROR | [x] Separate the @param and @return sections by a blank line.
359 | ERROR | [x] Separate the @return and @throws sections by a blank line.
372 | ERROR | [x] Expected 1 space after IF keyword; 0 found
374 | ERROR | [x] Expected 1 space after IF keyword; 0 found
376 | ERROR | [x] Expected 1 space after IF keyword; 0 found
426 | ERROR | [x] Expected 1 blank line after function; 0 found
427 | ERROR | [x] The closing brace for the class must have an empty line before it
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 After Patch.png9.33 KBgabriel.abdalla
#8 Before Patch.PNG32.65 KBgabriel.abdalla
#6 3230053-6.patch2.8 KBtakuma shimabukuro

Issue fork layout_builder_kit-3230053

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

marcusvsouza created an issue. See original summary.

marcusvsouza opened merge request !4

marcusvsouza’s picture

marcusvsouza commented
Assigned: marcusvsouza » Unassigned
Status: Active » Needs work
sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review

MR looks fine. Please review.

takuma shimabukuro’s picture

takuma shimabukuro commented
Assigned: Unassigned » takuma shimabukuro
takuma shimabukuro’s picture

takuma shimabukuro commented
StatusFileSize
new 3230053-6.patch2.8 KB

Steps performed:
1. Installed Layout Builder Kit with version 8.x-1.x
2. ran phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml LBKBaseComponent.php inside layout_builder_kit/src/Plugin/Block
3 fix all errors and warnings

takuma shimabukuro’s picture

takuma shimabukuro commented
Assigned: takuma shimabukuro » Unassigned
gabriel.abdalla’s picture

gabriel.abdalla commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before Patch.PNG32.65 KB
new After Patch.png9.33 KB

Hi, patch reviewed.

Steps performed:
(1) Got code from dev version.
(2) Run PHPCS with standard Drupal src/Plugin/Block/LBKBaseComponent.php
(3) PHPCS issues returned (image attached).
(4) Applied 3230053-6.patch.
(5) Run PHPCS again.
(6) PHPCS issues fixed (image attached).

alancunha’s picture

alancunha commented

Revised the MR using the phpcs against the file LBKBaseComponent.php and no errors were found.

aangel closed merge request !4

aangel’s picture

aangel commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.