Problem/Motivation

There are failing functional tests on the 8.x-3.x branch for Drupal 8.9.x. This makes it hard to validate issues.

Steps to reproduce

The latest test run is here: https://www.drupal.org/pift-ci-job/2158495

Proposed resolution

Investigate and fix the test suite. Could be revealing an underlying issue with the module.

Remaining tasks

Fix tests, document as best you can the issue that was causing the test fails to direct regression testing.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork amp-3229872

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

m4olivei created an issue. See original summary.

m4olivei opened merge request !5

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Status: Active » Reviewed & tested by the community

Yay! Tests passing on Drupal 8.

The test failures in Drupal 9 will be handled by #3186185: Current versions do not work with drupal 9.1.0.

  • m4olivei committed b9500f0 on 8.x-3.x 
    Issue #3229872 by m4olivei: Fix test failures on 8.x-3.x for Drupal 8.9....
m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented
Assigned: m4olivei » Unassigned
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-3.x.

The issue was first off, the AmpTextTrimmedFormatter class was overriding the viewElements method, and just overridding the #type. The way the parent method was implemented though meant that it applied the render elements info attributes such that the amp_processed_text was denied the chance to append it's #pre_render hooks. The fix was to copy / paste the parent method, not call the parent and make adjustments necessary to #type.

In addition I was gettng mixed test results still between local and Drupal CI. I adjusted the image test fixture HTML to have a self closing tag, which appears to have made it more reliable? That was a total guess. We'll see if it holds.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.