Remove "Commerce Base" to upgrade to Drupal 9.x ? [#3229867]

Hi,

Should this project in my 'requires' list be removed using Composer?
"drupalcommerce/commerce_base": "dev-8.x-1.x",

The Upgrade Status module reports that "Commerce Base" is in the files structure but not installed and suggests removing it.

Upgrade Status Module Report

My original Drupal 8 install was with Composer using:
composer create-project drupalcommerce/project-base XXXXXX --stability dev

I presently have Commerce 8.x-2.26 installed.

I'd like to upgrade to from Drupal 8.9.x to 9.2.x.

My current composer.json attached.

Thank you!

Comment	File	Size	Author
#10	issue-3229867-drupal9-compatibility.patch	1.52 KB	seorusus
	composer.json_.txt	4.23 KB	mlecha
	Drupal-9-upgrade-status-CHRC.png	20.57 KB	mlecha

Issue fork commerce-3229867

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3229867-remove-commerce-base compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

25 August 2021 at 18:01

mlecha created an issue. See original summary.

Comment #2

jsacksick commented 26 August 2021 at 08:03

Status:

Active

» Closed (won't fix)

With the abundance of support available in Drupal Answers, the Drupal focused Stack Exchange site, we are no longer answering support requests in the issue queue.

Support requests opened here will be closed (won't fix), so please search for existing answers or post new questions at:

https://drupal.stackexchange.com (using the drupal-commerce tag)

Comment #3

24 November 2021 at 11:38

firfin made their first commit to this issue’s fork.

Comment #4

firfin commented 24 November 2021 at 11:38

The question in stack exchange is here:
https://drupal.stackexchange.com/questions/305842/should-i-remove-commer...

Unfortunately there are no answers there either. And the answer is not clear from documentation either. Some help would be greatly appreciated.

Comment #5

firfin commented 24 November 2021 at 12:05

Status:

Closed (won't fix)

» Active

I think this deserves some attention. Many commerce sites were created using the 'project-base' on D8 and now need to be updated to D9.
Some best practice advice would be a great start.
The docs just state some info about updating Drupal Core, nothing about updating project-base itself or it's commerce_base requirement.

To me (and others apparently) it is unclear on how to proceed with updating.

Comment #6

jsacksick commented 24 November 2021 at 12:14

Status:

Active

» Fixed

drupalcommerce/project-baseis a composer template, it isn't a module... It shouldn't be required in your composer.json.

Comment #7

firfin commented 27 November 2021 at 12:16

So drupalcommerce/commerce_base is a requirement in project composer.json files which are based of the drupalcommerce/project-base template.

As far as I understand it, commerce_base is installed as an installation profile, not as a module. That is why it shows up in the 'Upgrade status' as not installed, I presume. It is probably just best to ignore this?

Also messages about swiftmailer (required by commerce_base) are generated, but this will sort itself out magically at some point in the future I suppose? With some future version of commerce_base.