Hi !

PHPCS reports a few coding standards violations against 8.x-2.x-dev.

Attached is a patch that fixes most of them. I have also opened a merge request for convenience https://git.drupalcode.org/project/publication_date/-/merge_requests/5/d...

This includes a fix for #3220692: Required parameter $bubbleable_metadata follows optional parameter

Thanks

CommentFileSizeAuthor
publication_date_8.x-2.x_coding_standards.patch24.11 KBfengtan

Issue fork publication_date-3229670

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fengtan created an issue. See original summary.

fengtan opened merge request !5

fengtan’s picture

fengtan
Location Montreal, Canada
commented
Issue summary: View changes
fengtan’s picture

fengtan
Location Montreal, Canada
commented
Issue summary: View changes
jchatard’s picture

jchatard commented
Status: Needs review » Reviewed & tested by the community

Works great, even on PHP 8.0.

A new release would be welcome.

Thanks,
Jérémy

Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented

Since this issue is scoped to "coding standards", I'd recommend applying the deprecated code feedback to a new, separate issue, as these 'Code Standard' issues are already unwieldy at scale.

mably’s picture

mably commented
Status: Reviewed & tested by the community » Closed (outdated)

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.