Problem/Motivation

Sites that use the Shortcode module on Drupal 7 should have configuration copied when they migrate to Drupal 8 or Drupal 9.

Proposed resolution

Map the plugin ID of the 'Shortcodes - html corrector' filter to match the D7 version.

CommentFileSizeAuthor
#2 shortcode-shortcode_corrector_filter_mapping-3229599-2.patch652 bytesn4r3n
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

n4r3n created an issue. See original summary.

n4r3n’s picture

n4r3n
he/him
Location Goa
CreditAttribution: n4r3n commented
FileSize
shortcode-shortcode_corrector_filter_mapping-3229599-2.patch652 bytes

Patch to map Shortcodes - html corrector filter.

Denes.Szabo’s picture

Denes.Szabo CreditAttribution: Denes.Szabo as a volunteer and commented

@n4r3n Thanks for your contribution!

Shouldn't we need to check the 'shortcode_text_corrector' existence in the $migration and add the new corrector id when it exists?

I mean: 

if (!empty($migration['process']['filters']['process']['id']['map']['shortcode_text_corrector'])) {
   // Add 7.x-2.x to 2.0.x filter ID mapping.
   $migration['process']['filters']['process']['id']['map']['shortcode_text_corrector'] = 'shortcode_corrector';
}
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Reviewed & tested by the community
Related issues: +#3106304: Migrate: add mapping for editor module's editor_align and editor_caption filters

#3: No, that's not necessary. We're creating that entry in the array/mapping :)

You can find a bunch of examples in contrib of this, and even one in Drupal core: #3106304: Migrate: add mapping for editor module's editor_align and editor_caption filters.

  • Denes.Szabo committed 4ac20451 on 2.0.x authored by n4r3n 
    Issue #3229599 by n4r3n: Drupal 7 → Drupal 8 migration path
Denes.Szabo’s picture

Denes.Szabo CreditAttribution: Denes.Szabo as a volunteer and commented

Thank you for your contribution, the 2.0.2 just released.

Denes.Szabo’s picture

Denes.Szabo CreditAttribution: Denes.Szabo as a volunteer and commented
Status: Reviewed & tested by the community » Fixed
Denes.Szabo’s picture

Denes.Szabo CreditAttribution: Denes.Szabo as a volunteer and commented
Status: Fixed » Closed (fixed)