Closed (fixed)
Project:
Drupal core
Version:
9.2.x-dev
Component:
Olivero theme
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
20 Aug 2021 at 13:05 UTC
Updated:
21 Sep 2021 at 14:09 UTC
Jump to comment: Most recent, Most recent file

It appears that even in languages with a
Comments
Comment #2
mherchelThis is straightforward to fix. Movie showing the fix is attached.
Note that this patch ensures this only happens when the image is present (we don't want to limit the width if the title if the image isn't present).
Tugboat preview to test this on is https://3229094-teaser-wrap-mzhdfnl5gcrurhq8owbxwhqw3is2iclf.tugboat.qa/
Comment #3
mherchelI guess the patch would be helpful for the review...
Comment #4
mherchelComment #5
rikki_iki commentedNice solution.
My only comment is there's no gap below the image, so the folded text sits up against it (evident in the vid from #1) - not sure if this really needs addressing, but moving the bottom margin from
.node__top-wrapperto both children would easily address it.Comment #6
rikki_iki commentedPatch to add moving the bottom margin to children. Otherwise same as #3 (interdiff of just pcss file)
There's a bit of space left to the right of the title after it folds (see screenshot)... not sure if it's worth addressing. It only really occurs under 300px
Comment #7
gauravvvv commentedFixed custom commands failed, Attached interdiff for same.
Comment #8
mherchelThanks for the patches! This looks perfect.
Note that @rikki_iki removed the bottom margin from
.node__top-wrapperand added it onto both of its descendants (which works great).Animated GIF attached.
Comment #11
lauriiiCommitted 3494a8f and pushed to 9.3.x. Also cherry-picked to 9.2.x because Olivero is experimental. Thanks!