Problem/Motivation

I would like to use this module for my site, but unfortunately it does not work. First I thought that the template outputs wrong values, but on closer inspection the Twig_Extension is deprecated. Therefore, currently no conversion of the email address takes place. I have tried it with the stable and dev version, both do not work. I use Drupal 9.2.4.

Steps to reproduce

Proposed resolution

* Create a patch that fixes the problem.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3229018-2.patch826 byteslarisse
Xnip2021-08-20_01-30-28.png143.66 KBzcht

Issue fork obfuscate_email-3229018

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zcht created an issue. See original summary.

larisse’s picture

larisse commented
Status: Active » Needs review
StatusFileSize
new 3229018-2.patch826 bytes

Hi @zcht!
Can you check if this patch work, please? =)

zcht’s picture

zcht commented

Hi Larisse, thanks for the patch. So the deprecation is gone, so the patch works, thanks :)

However, the email addresses are still output as plain. I understand correctly that I should see the data attribute in the source code? Or how else could I test this? :thinking:

zcht’s picture

zcht commented
Status: Needs review » Reviewed & tested by the community

My mistake, everything works as it should. Thanks for the patch, RTTB ++1 :)

zcht’s picture

zcht commented
schoenef’s picture

schoenef commented

Hi @b_sharpe, any chance this could be merged and released?

Thx a lot!

lucasfraulin made their first commit to this issue’s fork.

  • b_sharpe committed 427141f on 8.x-1.x 
    Issue #3229018 by larisse, lucasfraulin, zcht: Email address is no...
b_sharpe’s picture

b_sharpe commented
Status: Reviewed & tested by the community » Fixed

Put into dev, but before I cut a release I should probably look at the deprecation for BC, don't want to break a bunch of older installs

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jcnventura’s picture

jcnventura
Primary language English
commented

@b_sharpe, these changes remove support for Twig 1, so they break backward compatibility with Drupal 8. Make sure to remove Drupal 8 from core_version_requirement in the info.yml of both projects.