If the initial zoom is way smaller than the focus zoom, the first time trigger_geocode() is called the panning will be slightly off.
It seems to happen because Leaflet will pan with the initial zoom (which is low so the panning does not have to be super precise) and then zoom.
setZoomToFocus() should be called before mapSetCenter().
This way, when the panning happens, it already knows at what zoom level the marker should be into view.
I will submit a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Without patch (unzoomed).png | 189.7 KB | prudloff |
| #5 | Without patch.png | 179.04 KB | prudloff |
| #5 | With patch.png | 208.48 KB | prudloff |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !3
Comments
Comment #3
prudloff commentedComment #4
itamair commentedThanks for reporting this @prudloff
I tested your exact use case and self.mapSetCenter(mapid, position) and self.setZoomToFocus(mapid) are so close each other that they happen at the same time, and sequence is not really perceivable to me ...
I cannot reproduce at all what you define as "pans slight out of town".
May you post better evidence of your issue, such a short video recording of what you see?
Otherwise I still don't feel your correction is really needed ...
Comment #5
prudloff commentedThe sequence is not perceivable to me either. The problem is not that you can see the sequence but that the accuracy of the panning is based on the current zoom level (so the zoom should happen before the panning).
Here are screenshots with and without the patch.
Without the patch, the map is centered slight away from the marker (and if I unzoom, you can see the marker is slightly to the south-east).
Comment #6
avpadernoComment #8
itamair commentedCommitted into 3.0.x branch.