Unused use statement
(Drupal.Classes.UnusedUseStatement.UnusedUse)

A missing function doc comment
(Drupal.Commenting.FunctionComment.Missing)

Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
(Drupal.Commenting.InlineComment.InvalidEndChar)

There must be exactly one blank line before the tags in a doc comment
(Drupal.Commenting.DocComment.SpacingBeforeTags)

Expected "bool" but found "boolean" for parameter type
(Drupal.Commenting.FunctionComment.IncorrectParamVarName)

Opening brace should be on the same line as the declaration
(Drupal.Classes.ClassDeclaration.BraceOnNewLine)
CommentFileSizeAuthor
#17 symfony_mailer.coding-standards.3228605-interdiff-15-17.txt3.82 KBadamps
#17 symfony_mailer.coding-standards.3228605-17.patch12.82 KBadamps
#15 coding-standards-3228605-15.patch13.27 KBurvashi_vora
#11 symfony_mailer.coding-standards.3228605-11.patch36.23 KBadamps
#7 symfony_mailer.coding-standards.3228605-7.patch25.58 KBadamps
#2 symfony_mailer-fix_drupal_coding_standard_and_drupal_practice-3228605-14193198-1.x.dev_.patch5.27 KBomrmankar

Issue fork symfony_mailer-3228605

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

omrmankar created an issue. See original summary.

omrmankar’s picture

omrmankar
Primary language English
Location Pune, Maharashtra
commented
Assigned: omrmankar » Unassigned
Status: Needs work » Needs review
StatusFileSize
new symfony_mailer-fix_drupal_coding_standard_and_drupal_practice-3228605-14193198-1.x.dev_.patch5.27 KB

Hi,

I have created a patch that is working according to the phpcs standards and resolves all errors.

The patch is attached.

omrmankar’s picture

omrmankar
Primary language English
Location Pune, Maharashtra
commented
adamps’s picture

adamps commented
Status: Needs review » Postponed

Thanks, it's a good idea, however the project is still young and changing fast. Please can we come back to this in a month or two?

adamps’s picture

adamps commented
Status: Postponed » Active
adamps’s picture

adamps commented
Assigned: Unassigned » adamps
adamps’s picture

adamps commented
Status: Active » Needs review
StatusFileSize
new symfony_mailer.coding-standards.3228605-7.patch25.58 KB

  • AdamPS committed dba0d8e on 1.x 
    Issue #3228605 by omrmankar, AdamPS: Fix Drupal coding standard and...
adamps’s picture

adamps commented
Status: Needs review » Active

Fixed some of the easy/automatic ones

adamps’s picture

adamps commented
Assigned: adamps » Unassigned
adamps’s picture

adamps commented
Title: Fix Drupal coding standard and Drupal Practice » Fix Drupal coding standards
Status: Active » Needs review
StatusFileSize
new symfony_mailer.coding-standards.3228605-11.patch36.23 KB

  • AdamPS committed dab25e9 on 1.x 
    Issue #3228605 by AdamPS: Fix Drupal coding standards
adamps’s picture

adamps commented
Status: Needs review » Active
urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora
urvashi_vora’s picture

urvashi_vora commented
Status: Active » Needs review
StatusFileSize
new coding-standards-3228605-15.patch13.27 KB

Hi,

Please review this patch.

Thanks

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
adamps’s picture

adamps commented
StatusFileSize
new symfony_mailer.coding-standards.3228605-17.patch12.82 KB
new symfony_mailer.coding-standards.3228605-interdiff-15-17.txt3.82 KB

Great thanks for the patch. I made a few small changes mostly to comments.

  • AdamPS committed 401a8a5 on 1.x authored by urvashi_vora 
    Issue #3228605 by AdamPS, urvashi_vora: Fix Drupal coding standards
adamps’s picture

adamps commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.