Problem/Motivation

Recently discovered one of our sites was flagging a JS error that was coming from this module and breaking the rest of the JS from running. The error being "Uncaught ReferenceError: Drupal is not defined". I noticed in office_hours.libraries.yml that there was no reference to core/drupal?

I'm a little surprised that this hasn't been flagged previously so have created a patch and this seems to resolve the issue. Hope this helps and if you can give me some insight into how this would work without passing drupal.js to the office_hours.js that would be much appreciated!

CommentFileSizeAuthor
#2 drupal-not-defined-3227554-2.patch287 byteswelly

Comments

welly created an issue. See original summary.

welly’s picture

welly commented
StatusFileSize
new drupal-not-defined-3227554-2.patch287 bytes
johnv’s picture

johnv
Primary language Dutch
commented
Status: Active » Needs review

  • johnv committed 488f5ba on 8.x-1.x authored by welly 
    Issue #3227554 by welly: Uncaught ReferenceError: Drupal is not defined
johnv’s picture

johnv
Primary language Dutch
commented
Status: Needs review » Fixed

Hmm, strange.
But other modules have this , too, so committed as-is.

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.