Going through the module, I found several instances of sloppy exception handling (some of them due to Core’s much, much sloppier exception handling) in our code, which we should fix in the interest of clarity and stability.

CommentFileSizeAuthor
#3 3226933-3--exception_handling.patch7.75 KBdrunken monkey
#3 3226933-3--exception_handling--interdiff.txt1.26 KBdrunken monkey
#2 3226933-2--exception_handling.patch7.25 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3226933-2--exception_handling.patch7.25 KB
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
StatusFileSize
new 3226933-3--exception_handling--interdiff.txt1.26 KB
new 3226933-3--exception_handling.patch7.75 KB

Based on #3133997: Avoid query caching in Search API when a Search API Solr Exception is thrown, maybe let’s also set the cache max age of the query to 0 in case of database exceptions? Or should we attempt to determine whether they are temporary (e.g., DB server outage) or persistent (e.g., we generate an invalid query)?
I guess we are on the safe side caching less for now …

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Committed.

  • drunken monkey committed 0f0cc20 on 8.x-1.x 
    Issue #3226933 by drunken monkey: Fixed some exception handling problems...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.