Add separate permission for administering configuration vs. unblocking users

Sounds good. Can you provide a patch?

No worries. Maybe I do it when I'm ready reviewing the issues. Thanks in advance!

@batigolix little sidenote, please specify the 2.2.x branch as the repositories default branch, so people working on the module do not get confused AND automatic issue branch creation won't use 2.0.x as their base repo, thanks!

Rebased the fork on 2.2.x maybe we can redirect the MR to 2.2.x instead of 2.0.x?

@batigolix Also note, that #3270116: Better to hide "Flood Control settings page" link from top markup if the user doesn't has a permission introduced a new "access flood control settings page" which is nowhere used in 2.2.x. I don't really know if we should remove this permission here and keep @Anybody's permission changes to the "flood_control.settings" page, or if we should use the "access flood control settings page" instead.

I think we just keep Anybody's change and remove the permission again, as it has no use. If you are against this change, feel free to revert it! :)

EDIT: The permission is actually used, but not for the admin page! Quite confusing to say the least, so I will replace the occurrence with "administer flood unblock".

All right, all done and fixed!

I additionally tested the update process, to see if the update hook works as expected, and it does! Please review! :)

Tests need further work, I'll resume my work here tomorrow.

@batigolix, further note: Enabling automated testing for issue branches would be also a nice addition! :)

All finished! Tests are all green locally!

@batigolix I hope you don't mind, that I tinkered quite a lot with your tests! :)

Please review.

Already tested the update hook manually, and normal access is secured by the tests.

I had issues patching this MR to the new 2.2.4 branch so i've made a patch on the latest available branch.

Both the MR as the patch won't apply to the new 2.3.x branch. Could you please check?

Created a new patch, it hasn't changed that much, but just enough for it to fail to apply apparently.

Patch applies well to 2.3.x

This is fixed in the dev version, will create a new release version today.

Awesome! Thank you @fabianderijk!

Hello, Some olders permissions appears in drupal 10 upgrade status with an alert :
- access flood control settings page
- access flood unblock

To remove those alerts, I add to revoke them in flood_control.install by adding :

function flood_control_update_9202() {
  $roles = user_role_names(FALSE, 'access flood control settings page');
  foreach ($roles as $roleKey => $roleName) {
    user_role_revoke_permissions($roleKey, [
      'access flood control settings page',
    ]);
  }

}

function flood_control_update_9203() {
  $roles = user_role_names(FALSE, 'access flood unblock');
  foreach ($roles as $roleKey => $roleName) {
    user_role_revoke_permissions($roleKey, [
      'access flood unblock',
    ]);
  }

}

Do you think, it could block Drupal 10 upgrade ?

@everhee I just encountered the same problem, opened a new issue: #3361842: Revoke old permissions from roles.